New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weighted validators (BFT-408, BFT-424) #77

Merged

ElFantasma merged 45 commits into main from weighted_validators

Apr 17, 2024

Contributor

ElFantasma commented Mar 14, 2024

What ❔

Add weights to the validator set and change the consensus threshold rules to require >80% of weight.

Why ❔

We need for the L1 contracts to only accept blocks that were built by our node (which is the single leader). We can give more weight to our node, so that a QC isn't valid unless it signs. In turn this will be useful in the future

ElFantasma added 18 commits

March 11, 2024 10:32


          Added weights to ValidatorSet

08dbad0


          Added WeightedValidator to represent weighted validators in a Validat…

67a1e50

…orSet


          Merge branch 'main' into weighted_validators

664c4cb


          Signers weight calculation

b48ec12


          Completed test and renamed ValidatorSet to ValidatorCommittee

0707c46


          Simplified weights representation

416517a


          Different weights per validator in test

e6425e4


          Merge branch 'main' into weighted_validators

d9c3826


          Fixed outdated names

7689c4f


          Merge branch 'main' into weighted_validators

f6a3b52


          Merge branch 'main' into weighted_validators

283ae7c


          Updated threshold logic to use weights instead of amount of signers

4c8e981


          Fixed asserts and tests to use weights instead of amount of signers

5ff923d


          Fixing check for weight before adding new signature in replica commit

532a9aa


          Merge branch 'main' into weighted_validators

8f52b61


          removed unnecessary borrow

955d778


          fix typo

e20cdbd


          minor style fixes

8652d0e

ElFantasma marked this pull request as ready for review

March 22, 2024 19:42

ElFantasma requested a review from pompon0 as a code owner

March 22, 2024 19:42

pompon0 reviewed

View reviewed changes

node/actors/bft/src/leader/replica_commit.rs Outdated Show resolved Hide resolved

pompon0 reviewed

View reviewed changes

node/actors/bft/src/leader/replica_commit.rs Outdated Show resolved Hide resolved

pompon0 reviewed

View reviewed changes

node/actors/bft/src/leader/replica_prepare.rs Outdated Show resolved Hide resolved

pompon0 reviewed

View reviewed changes

node/actors/bft/src/testonly/ut_harness.rs Outdated Show resolved Hide resolved

pompon0 reviewed

View reviewed changes

node/libs/roles/src/proto/validator.proto Outdated Show resolved Hide resolved

pompon0 reviewed

View reviewed changes

node/libs/roles/src/validator/conv.rs Outdated Show resolved Hide resolved

pompon0 reviewed

View reviewed changes

node/libs/roles/src/validator/messages/consensus.rs Show resolved Hide resolved

pompon0 reviewed

View reviewed changes

node/libs/roles/src/validator/messages/consensus.rs Outdated Show resolved Hide resolved

pompon0 reviewed

View reviewed changes

node/libs/roles/src/validator/messages/consensus.rs Outdated Show resolved Hide resolved

pompon0 reviewed

View reviewed changes

node/libs/roles/src/validator/messages/consensus.rs Outdated Show resolved Hide resolved

pompon0 reviewed

View reviewed changes

node/actors/bft/src/testonly/ut_harness.rs Outdated Show resolved Hide resolved

pompon0 reviewed

View reviewed changes

node/actors/bft/src/leader/replica_commit.rs Outdated Show resolved Hide resolved

node/actors/bft/src/leader/replica_commit.rs Outdated Show resolved Hide resolved

node/actors/bft/src/tests.rs Outdated Show resolved Hide resolved

node/libs/roles/src/validator/messages/consensus.rs Outdated Show resolved Hide resolved

node/libs/roles/src/validator/messages/consensus.rs Show resolved Hide resolved

node/libs/roles/src/validator/testonly.rs Outdated Show resolved Hide resolved

node/libs/roles/src/validator/tests.rs Outdated Show resolved Hide resolved

ElFantasma added 6 commits

April 11, 2024 19:15


          Making it backwards compatible and modifying tests to check it

89316f1


          some more corrections from PR review

dccfaad


          Fixing protocol buffer backward compatibility

c074717


          Several PR review corrections

2f58168


          Removed redundant BTtreeMap

1764d13


          Removed commit_message_cache as it is no longer needed

0df72f9

ElFantasma requested review from pompon0 and brunoffranca

April 12, 2024 21:02

moshababo mentioned this pull request

Support multiple leader-selection modes (BFT-416) #96

Merged

pompon0 reviewed

View reviewed changes

node/actors/bft/src/leader/replica_prepare.rs Outdated Show resolved Hide resolved

pompon0 reviewed

View reviewed changes

node/actors/bft/src/leader/replica_commit.rs Show resolved Hide resolved

pompon0 reviewed

View reviewed changes

node/libs/roles/src/validator/messages/tests.rs Show resolved Hide resolved

pompon0 reviewed

View reviewed changes

node/libs/roles/src/proto/validator.proto Show resolved Hide resolved

pompon0 reviewed

View reviewed changes

node/libs/roles/src/validator/conv.rs Show resolved Hide resolved

pompon0 reviewed

View reviewed changes

node/libs/roles/src/validator/messages/consensus.rs Show resolved Hide resolved

ElFantasma added 2 commits

April 15, 2024 12:21


          Addressed several suggestions in PR review

5afab58


          Improved some tests and added zero weight validator test

d6f2a8a

pompon0 reviewed

View reviewed changes

node/libs/roles/src/validator/conv.rs Outdated Show resolved Hide resolved

pompon0 reviewed

View reviewed changes

node/libs/roles/src/validator/messages/tests.rs Outdated Show resolved Hide resolved

pompon0 reviewed

View reviewed changes

node/libs/roles/src/validator/messages/tests.rs Show resolved Hide resolved

pompon0 reviewed

View reviewed changes

node/libs/roles/src/validator/tests.rs Outdated Show resolved Hide resolved

pompon0 approved these changes

View reviewed changes

brunoffranca approved these changes

View reviewed changes

ElFantasma added 3 commits

April 16, 2024 14:24


          Proper duplicate signature check and some suggested code improvements

5e13fb3


          Rewrote minimal validator amount assertion in UTHarness::new_many()

608328c


          Merge branch 'main' into weighted_validators

aa8e0e2

ElFantasma merged commit 8f93e07 into main

5 checks passed

ElFantasma deleted the weighted_validators branch

April 17, 2024 14:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet